feat: elegibility_appt_dates runtime calculations #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanseto
changed the title
andrey-canon
requested changes
Jul 15, 2024
Comment on lines
+328
to
+329
| exam_metadata["eligibility_appt_date_first"] = timezone.now().strftime("%Y/%m/%d %H:%M:%S") | ||
| exam_metadata["eligibility_appt_date_last"] = ( |
There was a problem hiding this comment.
please remove these fields from the required_fields variable
| @override_settings() | ||
| def test_get_exam_data_success(self): | ||
| def test_get_exam_data_success(self, mock_now): |
There was a problem hiding this comment.
This is not testing your changes... indeed if you revert the pipeline changes this test passes
andrey-canon
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat: elegibility_appt_dates runtime calculations in exam_metadata.
Testing instructions
After
Check in audit the update data.
Additional information
Include anything else that will help reviewers and consumers understand the change.
Checklist for Merge